Page 1 of 1

"Gifted" Skills not updating till user has relogged

PostPosted: Sun Dec 30, 2018 5:10 am
by SpaceReptile
Description: when using the [Give] option on the Prerequisites tab, the skills dont update till you have relogged

items affected/used: any skill that is a prerequisite for a module or ship

how to replicate: use the [Give] option for a modules prerequisite skills and then try to use said module of ship afterwards, it will claim that you are missing skills
this will be gone once you have logged out and back in again

Visual aid: https://i.imgur.com/tZfIOUA.png / https://i.imgur.com/YM7V6oP.mp4 (main skill may show w/ a green tick or a red ring after gifting the skills)

Re: "Gifted" Skills not updating till user has relogged

PostPosted: Sun Dec 30, 2018 9:20 am
by DaVinci
Afaik, it's not a bug per-se - client's processing of skills is a bit funky and requires character to have both skill at certain level AND more-less correct amount of skill points. Even tho skill is updated instantly, skill points are calculated when character logs in - it is a part of login procedure.
It might be a point for improvement sometime later on...unless it was already altered. Then yep, that would be a bug.

Re: "Gifted" Skills not updating till user has relogged

PostPosted: Mon Dec 31, 2018 3:18 am
by Allan
the open window (skill prereqs) does not update while open. not sure how live makes it update. (its' low on my list)
however, the 'give' button will put the skillpoints at the even-number for the level needed.
now, the client code for skill requirements is kinda odd....i'll have to look at it again to remember it correctly.....but the jest is this....
if you have EXACTLY the points required for the level needed, it dont work right all the time.
a workaround is to train the skil for a second or two, and try again.
skillpoints, as DV said, are checked (and corrected as needed) on login, and also when they are put into the training queue.
something else to look at is when using the "GIVE" button, there are some occasions where the skill level is sent as a float and the level will show "0.0" on skills tab of char sheet.
when this happens (and i still dont know why), then you can put that skill in the training queue and it will be fixed, based on level of skill.

so, try those, and if none of them work, post again as it would be a bug.

Re: "Gifted" Skills not updating till user has relogged

PostPosted: Tue Jan 01, 2019 12:44 am
by Groove
This can likely be fixed by sending an OnSkillTrained event to the client.

Re: "Gifted" Skills not updating till user has relogged

PostPosted: Tue Jan 01, 2019 6:38 pm
by Allan
main has been updated to do just that.
will need testing to verify

Re: "Gifted" Skills not updating till user has relogged

PostPosted: Wed Jan 02, 2019 1:06 am
by Allan
i've tested this and it's still not updating client.

as this is a GameMaster command, it's not required for normal gameplay, and not considered a bug.
it probably wont be updated any further.